Vote Details for "Net_MAC" by cweiske

» Details
» Comment
Please make private class vars protected unless absolutely needed.
Further, I don't know from looking at the code when to use the normal constructor, and when factory(). IMO the parameters of the factory could be checked in the constructor, throwing an exception on error.

By the way, PHP5 supports typed parameters so you don't have to check the type yourself:
function Net_MAC(MDB2_Driver_Common $db) {}