Comments for "File_XSN"

» Submit Your Comment
Comments are only accepted during the "Proposal" phase. This proposal is currently in the "Finished" phase.
» Comments
  • Philippe Jausions  [2008-01-29 16:16 UTC]

    convertFieldNames() could potentially generates conflicting names (i.e. what happens when 2 fields are named first-name and first_name in the same document) But since a user can use a different conversion function, it may not be too big of a deal.

    The fields' name need to be better handled to prevent PHP code injection in the convertTempate() method.

    convertTemplate() should be split from the base class into separate classes to allow the support for any template engine (Savant, Smarty, etc...)
  • Chuck Burgess  [2008-01-31 02:02 UTC]

    LGPL v3... /me smiles broadly

    Philippe's point about convertFieldNames() could certainly make for a nasty-to-debug problem if it caused $first-name to collide with $first_name. Maybe consider making it default to changing one dash to three underscores, which will avoid such a 1-for-1 collision, plus it would make the converted variable stand out more when viewed in a debug session.