Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.4.1

Bug #600 Inconsitency in APPEND between methods
Submitted: 2004-01-19 21:38 UTC
From: simon dot hamilton at ntlworld dot com Assigned: datenpunk
Status: Closed Package: DB_NestedSet
PHP Version: Irrelevant OS: OpenBSD 3.4
Roadmaps: (Not assigned)    

 [2004-01-19 21:38 UTC] simon dot hamilton at ntlworld dot com
Description: ------------ When changing the sortMode in getAllNodes, thus calling a SQL query direct in getAllNodes or handing off to getBranch with the other option the SQL is different. In getAllNodes the append data must include WHERE, whereas in getBranch WHERE is included in the query and not required in the Append data. This caused me a headache for a while until I scarred the code and eventually found the problem. It would be prudent to make them the same, and NOT include WHERE in the SQL but to allow it to be passed in Append since if there is no append, the WHERE condition would be empty. I tried posting this bug a week ago, but it didnt go, and also emailed the maintainer but with no acknowledgment, so here it is again. Thanks! Simon H Reproduce code: --------------- not necessary Expected result: ---------------- not necessary Actual result: -------------- not necessary


 [2004-01-26 10:58 UTC] beat dot kipfer at balcab dot ch
I had the same problem on filtering data. In my mind the best resolution should be to add a new "APPEND" as "ADD" or something like that.
 [2004-01-26 11:11 UTC] datenpunk at php dot net
This will be fixed in the future versions. I only have to find a way to maintain BC as some users may allready append 'WHERE' to the queries. Your E-Mail must have slipped trough. Normally you get a quick response for each request sent to me. Thank's for your report!
 [2004-03-31 10:29 UTC] datenpunk at php dot net
Following Beat's suggestion I now added $addSQL['where'] which takes a condition like A='B' AND C='D'. No 'AND' or 'WHERE' is now needed at the beginning. The append param shouldn't be used for such conditions anymore. Fixed in CVS - a new release will be out very soon. Thanks for your reports and suggestions! -- Daniel Khan