Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.5.1

Bug #18924 Test can't be run for sources
Submitted: 2011-10-23 12:08 UTC
From: remicollet Assigned: avb
Status: Closed Package: HTTP_Request2 (version 2.0.0)
PHP Version: 5.3.8 OS: GNU/Linux (Fedora 15)
Roadmaps: 2.1.0    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 44 + 16 = ?

 
 [2011-10-23 12:08 UTC] remicollet (Remi Collet)
Description: ------------ Test can only be run from installed package. All include need to have a conditionnal path

Comments

 [2011-10-24 05:54 UTC] doconnor (Daniel O'Connor)
(or tweak the dir structure, package.xml so that $ phpunit tests/ will pick up the right include path)
 [2011-10-26 17:42 UTC] avb (Alexey Borzov)
-Status: Open +Status: Closed -Assigned To: +Assigned To: avb
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. -- I've changed the dir structure and now change include_path in TestHelper.php, tests seem to run OK from checkout.
 [2011-10-26 19:45 UTC] remicollet (Remi Collet)
Can you please also check, in HTTP/Request2/CookieJar.php if (0 === strpos($path, '@' . 'data_dir@')) { This test is always false. So test always used public-suffix-list.php from installed version, not from sources. Should be ok if (0 === strpos($path, '@' . '@data_dir@')) {
 [2011-10-26 19:59 UTC] avb (Alexey Borzov)
The test is correct, I checked here and it includes different versions of public-suffix-list.php when run from installation and from SVN checkout. Try a clean checkout, maybe you have some local changes.
 [2011-10-26 20:12 UTC] remicollet (Remi Collet)
You're right. Test is ok. Thanks for the fix, and sorry for the noise.