Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.1.2

Bug #14399 Multiple bugs in Net_URL2
Submitted: 2008-07-24 15:20 UTC
From: rkirilov Assigned: schmidt
Status: Closed Package: Net_URL2 (version 0.2.0)
PHP Version: 5.2.4 OS:
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 47 + 4 = ?

 
 [2008-07-24 15:20 UTC] rkirilov (Radoslav Kirilov)
Description: ------------ The patches provided speak for themselves. 1) Missing value for the second parameter of $this->setOption At line 133 - $this->setOption($optionName); + $this->setOption($optionName, $value); 2) The query string should contain anything to the fragment separator, and can be '' (empty string) At line 151 - if (preg_match('@^\?([^#]+)@', $url, $reg)) { + if (preg_match('@^\?([^#]*)@', $url, $reg)) { 3) There are some missing (unused) properties that are tried to be set, and not the right one At line 311 - $this->user = false; + $this->userinfo = false; At line 312 - $this->pass = false; 4) The userinfo (user:pass) can be omitted/empty but in that case there is no need from @ separator in the normalized url At line 315 - if (preg_match('@^(([^\@]+)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { + if (preg_match('@^(([^\@]*)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { At line 316 - if ($reg[1]) { + if ($reg[1] && strlen($reg[2])) { P.S First I would like to apologize for the bad posted bug report (may be). Second I haven`t read RFCs but I tested the behavior with common browsers.

Comments

 [2008-07-26 02:57 UTC] doconnor (Daniel O'Connor)
Radoslav, any chance of lodging other bugs for the individual problems? That way we can improve our unit test coverage :) Anyway, thanks for the patches - they are a little outdated against the CVS version, but we can still probably fix 'em.
 [2008-07-27 09:23 UTC] schmidt (Christian Schmidt)
The fixe for line 133, 311, 312 and 315 have now been applied - thanks. AFAICT line 151 has always looked like the line you are suggesting, hasn't it? WRT line 316, the RFC does not explicitly say that an empty userinfo is equivalent to a non-existing userinfo, so I am reluctant about changing this. I guess one could argue, that trying to access a resouce with an explicitly set empty password is different from accessing it without having supplied a password at all. BTW, the URL parsing done in the constructor is not trying to do any normalization but rather store the various parts in a verbatim fashion. Any normalization is done in normalize().
 [2011-03-13 07:00 UTC] till (Till Klampaeckel)
-Assigned To: +Assigned To: schmidt
Wanna make a decision?
 [2011-10-20 05:31 UTC] davidc (David Coallier)
-Status: Verified +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. I believe all of those that make sense to fixed are already fixed in SVN.